-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Google Drive - create file from template and store in shared drive #19275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughThe PR adds a new Changes
Sequence DiagramsequenceDiagram
participant User as User
participant Action as Action: Create File from Template
participant GDrive as Google Drive API
Note over User,Action: Before: Single drive prop<br/>After: Separate drive & destinationDrive
User->>Action: Select template (source)
User->>Action: Select destination folder
rect rgb(240, 248, 255)
Note over Action: New Logic
Action->>Action: Validate template from drive
Action->>Action: Check destinationDrive<br/>for shared-drive status
end
Action->>GDrive: Create file in destination folder<br/>(with correct drive context)
GDrive-->>Action: File created
Action-->>User: Success
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs(6 hunks)components/google_drive/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Verify TypeScript components
🔇 Additional comments (3)
components/google_drive/package.json (1)
3-3: Package version bump is consistent with action changesVersion increment to
1.4.1aligns with the updated action (0.1.18) and is appropriate for this behavioral expansion.components/google_drive/actions/create-file-from-template/create-file-from-template.mjs (2)
12-12: Action version bump matches the new behaviorUpdating the action version to
0.1.18is appropriate for introducing the new destination drive behavior without breaking the key or name.
21-28: Template vs destination drive separation looks correctSplitting the props into:
drive(now labeled “Drive Containing Template”) for scopingtemplateId, anddestinationDrivefor scopingfolderId,cleanly models the bugfix requirement: template and destination folder can live on different drives, while the folder picker stays tied to the destination drive.
Also applies to: 40-59
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs
Show resolved
Hide resolved
jcortes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 lgtm! Ready for QA!
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Resolves #19231
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.