Pull base repo #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename fr_QC to fr_CA * Formal deprecation of fr_QC
* cs_CZ word list * tests, removed abbreviation, improved help text for provider
* Windows 10 * Android * Apple
typing.Literal is available since Python 3.8, and the code uses typing_extensions only if it's unavailable. Therefore, typing_extensions aren't used at all with Python 3.8+ and the dependency is unnecessary for new Python versions.
1. It usually go to max_value or min_value when it has a low numbers. 2. It always happen when you set a min_value for really big numbers. They need bigger than 10*100"
* Add black check to tox.ini and CI * Modify isort config to be compatible with black Details see: https://pycqa.github.io/isort/docs/configuration/black_compatibility.html * Format the whole codebase with black * Update coding_style documentation * Remove flake8-commas flake8-commas is deprecated. The maintainers recommend using black instead (https://github.com/PyCQA/flake8-commas/) * Ignore E203 warning from flake8 as warning is not PEP 8 compliant https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8
* added tests * added `add_element` method * typo * removed double raise * Update __init__.py * linting * linting * fixed linting + added documentation to README * fixed isort * fixed merge and linting issues * Update README.rst Co-authored-by: omri374 <omri.mendels@microsoft.com> Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
This reverts commit 41506f3.
* Add provider for French SSN 15 digit French social security number is added. Besides gender, birth month and year it contains information about birthplace. I decided to create a list with the main municipality per department to create realistic data for this part of the SSN (department + municipality id = code INSEE) Fix: #1510 * Add missing trailing commas * Fix error in min value of month_of_birth * Reformat with black afte rebase
French landline numbers (starting with 01, 02, 03, 04, 05) are limited to well-known area codes. This is taken into account when generating the phone numbers. Mobile phone numbers starting with 07 are also added. Fixes: #1516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Brief summary of the changes
What was wrong
Description of what was the root cause of the issue.
How this fixes it
Description of how the changes fix the issue.
Fixes #...