Skip to content

Update the music to the new format and utilize some of the new songs - #3044

Merged
IntegratedQuantum merged 22 commits into
PixelGuys:masterfrom
codemob-dev:new-music
May 15, 2026
Merged

Update the music to the new format and utilize some of the new songs#3044
IntegratedQuantum merged 22 commits into
PixelGuys:masterfrom
codemob-dev:new-music

Conversation

@codemob-dev

Copy link
Copy Markdown
Contributor

Progress towards #1835

@codemob-dev codemob-dev moved this to Waiting for artistic review in PRs to review May 6, 2026
@ikabod-kee

Copy link
Copy Markdown
Collaborator

I will check this out, though not for the purposes of reviewing where the music is placed. Thank you for doing this.

@ikabod-kee

Copy link
Copy Markdown
Collaborator

Seems to be all formatted correctly. I will give you a heads-up that the folder name for my music will be changed to simply "ikabod" when PixelGuys/Cubyz-Assets#17 is merged.

@ikabod-kee ikabod-kee moved this from Waiting for artistic review to Easy to Review in PRs to review May 7, 2026
@IntegratedQuantum

Copy link
Copy Markdown
Member

I will check this out, though not for the purposes of reviewing where the music is placed.

Wait why not?

@ikabod-kee

Copy link
Copy Markdown
Collaborator

I felt it unecessary to do so considering the music system will be overhauled at some point, but I realize that there's a pretty high chance that won't be done until much later, so i will go in and see if the music fits.

Tomorrow, though :P

@ikabod-kee ikabod-kee moved this from Easy to Review to Waiting for artistic review in PRs to review May 12, 2026
@ikabod-kee

Copy link
Copy Markdown
Collaborator

My thoughts:

  • I really like the choice to use Hands 1 as the small mushroom caves theme, and Hands 2 as the big mushroom caves theme. That's a really creative usage of that song that I wouldn't have thought of.
  • Chimes in the crystal caves shouldn't fit, but it does somehow. I actually find it funny that most, if not all of my songs ended up in the caves. XD

What you should change:

  • Do not use Cubyz Remastered in any biome. That song is reserved for the title screen.

@ikabod-kee

Copy link
Copy Markdown
Collaborator

Oh yeah, and Scoria should play in hot cave biomes such as the basalt caves.

@codemob-dev

Copy link
Copy Markdown
Contributor Author

Do not use Cubyz Remastered in any biome. That song is reserved for the title screen.

Oh yeah, and Scoria should play in hot cave biomes such as the basalt caves.

Fixed!

@ikabod-kee

Copy link
Copy Markdown
Collaborator

Okay, now @IntegratedQuantum.

Since both PixelGuys/Cubyz-Assets#17 and this PR are fixed, which one will you merge first? I think you should merge mine as it has the new folder name, so it can be fixed in this PR.

@ikabod-kee

Copy link
Copy Markdown
Collaborator

Alright, this PR will need to be changed:

Hands I, Hands II, and Atlantis are now removed, so please find alternatives to them.
Additionally, "ikabodbtw" has been renamed to just "ikabod"

@IntegratedQuantum

Copy link
Copy Markdown
Member

To do so you will need to update the dependency in the build.zig.zon to the new release which will be created in a few minutes

@codemob-dev

Copy link
Copy Markdown
Contributor Author

It should be all working now!

Comment thread assets/cubyz/biomes/ocean/temperate/island/_defaults.zig.zon Outdated
Comment thread assets/cubyz/biomes/ocean/warm/island/_defaults.zig.zon Outdated
Comment thread assets/cubyz/biomes/rare/phantasmal_archipelago.zig.zon Outdated
Comment thread assets/cubyz/biomes/ocean/cold/island/_defaults.zig.zon Outdated
@codemob-dev
codemob-dev requested a review from ikabod-kee May 14, 2026 18:55
@codemob-dev

Copy link
Copy Markdown
Contributor Author

Fixed!

@ikabod-kee ikabod-kee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, seems good!

@ikabod-kee ikabod-kee moved this from Waiting for artistic review to Easy to Review in PRs to review May 14, 2026
@codemob-dev

Copy link
Copy Markdown
Contributor Author

Got the CI working!

@IntegratedQuantum IntegratedQuantum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include some of the songs from PixelGuys/Cubyz-Assets#23 particularly fridgid feelings intended for cold biomes, and hypoxia intended for barren biomes (see PixelGuys/Cubyz-Assets#23 (comment))

@ikabod-kee ikabod-kee moved this from Easy to Review to In review in PRs to review May 14, 2026
Comment thread assets/cubyz/biomes/desert/hoodoos/_defaults.zig.zon Outdated
@IntegratedQuantum
IntegratedQuantum merged commit 3ae7fa7 into PixelGuys:master May 15, 2026
1 check passed
@Wbjitscool

Copy link
Copy Markdown

what happened to in the depths?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants