Fixes UI and player visibility on Navbar Corner Radius Screen. - #77
Merged
Conversation
This commit addresses two issues on the Navbar Corner Radius screen: 1. The mini-player is now correctly hidden when the screen is active. This was fixed by adjusting the height calculation in `UnifiedPlayerSheet.kt` to ensure its height collapses to zero when the `hideNavBar` flag is true. 2. The screen's UI has been updated from a hardcoded black and white theme to use Material 3 colors from the application's theme, ensuring high contrast and a consistent look and feel. Testing: Unit tests could not be run due to the execution environment lacking an Android SDK configuration. The changes were purely in the UI layer and were validated through a successful code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two issues on the Navbar Corner Radius screen:
UnifiedPlayerSheet.ktto ensure its height collapses to zero when thehideNavBarflag is true.Testing:
Unit tests could not be run due to the execution environment lacking an Android SDK configuration. The changes were purely in the UI layer and were validated through a successful code review.