fix(catering): remove ability to edit existing orders when field disabled (PPT-1340) (PPT-1339) - #386
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
w-le
marked this pull request as draft
May 2, 2024 04:31
Contributor
|
Thanks, once done remove Draft and I'll get @KesterJJ to test |
MrYuion
marked this pull request as ready for review
May 6, 2024 04:11
Contributor
|
Hey @KesterJJ can I get a test of this one? Deploy this build branch to bm-stg workplace-pos, Thanks |
jeremyw24
changed the title
Contributor
|
Tested working |
w-le
reviewed
May 8, 2024
| ).length > 0 | ||
| ); | ||
| if ( | ||
| can_cater && |
Contributor
There was a problem hiding this comment.
Hey @MrYuion is this catering var relevant inside this assets function? Or is it just a leftover from copy/paste that shouldn't be here?
w-le
reviewed
May 8, 2024
| this.form.getRawValue(); | ||
| const time_changed = | ||
| !id || | ||
| (catering?.length && |
Contributor
There was a problem hiding this comment.
Hey @MrYuion is this catering var relevant inside this assets function? Or is it just a leftover from copy/paste that shouldn't be here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.