Skip to content

feat(api): add typed defPersistence to Queue spec#24

Merged
konih merged 2 commits into
mainfrom
feat/phase-8a-queue-defpersistence
Jun 14, 2026
Merged

feat(api): add typed defPersistence to Queue spec#24
konih merged 2 commits into
mainfrom
feat/phase-8a-queue-defpersistence

Conversation

@konih

@konih konih commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds Queue.spec.defPersistence (yes/no enum) for MQSC DEFPSIST per Phase 8a continuation (ADR-0021).
  • CEL mutual-exclusion vs attributes.defpsist uses has() guards (same pattern as maxDepth/description after fix(api): guard Queue description CEL with has() #23).
  • Controller folds typed field into the mqadmin attribute map; unit + envtest CEL rejection when both are set.
  • Regenerated CRDs, Helm CRD sync, and schema goldens.

Test plan

  • task verify
  • task lint
  • task test:run (91.3% internal coverage)
  • task test:schema
  • CI E2E (kustomize + helm)

konih added 2 commits June 14, 2026 03:21
Promote MQSC DEFPSIST to Queue.spec.defPersistence with yes/no enum,
CEL exclusivity vs attributes.defpsist (has() guards), controller fold,
and schema goldens per Phase 8a continuation.
golines corrupts '' to a smart quote in long XValidation markers; enum
+has() is sufficient (same pattern as maxDepth pointer field).
@konih
konih merged commit b739d3a into main Jun 14, 2026
14 checks passed
@konih
konih deleted the feat/phase-8a-queue-defpersistence branch June 14, 2026 01:42
konih added a commit that referenced this pull request Jul 10, 2026
* feat(api): ✨ add typed defPersistence to Queue spec

Promote MQSC DEFPSIST to Queue.spec.defPersistence with yes/no enum,
CEL exclusivity vs attributes.defpsist (has() guards), controller fold,
and schema goldens per Phase 8a continuation.

* fix(api): 🐛 drop empty-string CEL guard on defPersistence

golines corrupts '' to a smart quote in long XValidation markers; enum
+has() is sufficient (same pattern as maxDepth pointer field).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant