⬆️ chore(deps): migrate jsonschema from v5 to v6 - #25
Merged
Conversation
Renovate's major branch added v6 beside v5 and left go.sum incomplete. Compile via UnmarshalJSON+AddResource, map Required/AdditionalProperties kinds to JSON pointers, and gate go.mod so v5 cannot return.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
v6 ValidationError.Error panics when ErrorKind is nil; the leaf/fallback paths now use a nil-safe message helper, proven by package tests.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonschema/v5withv6.0.3(the Renovate major branch was not mergeable: dual require + incompletego.sum).UnmarshalJSON+AddResource) and pointer extraction viakind.Required/kind.AdditionalProperties.hack/test/jsonschema_v6_test.shfails if v5 remains ingo.mod.golang.org/x/textmoves to v0.39.0 (GO-2026-5970) because v6 uses it;x/modfollows as a direct import ofinternal/render.Test plan
go.mod, green aftergo test ./internal/validate/(pointered violations still hold)task checkgreen locally