fix(tasks): prune finished task history#138
Merged
PleasePrompto merged 1 commit intoJul 12, 2026
Merged
Conversation
Owner
|
Thanks — the core logic here is solid: the retention pruning can't touch running/waiting tasks, the age+count criteria merge cleanly, and the hub maintenance test is well built. A few things before un-drafting:
Happy to merge once those are in. 👍 |
attid
force-pushed
the
fix/task-retention-cleanup
branch
from
July 10, 2026 15:13
419e7ac to
0a1b437
Compare
PleasePrompto
marked this pull request as ready for review
July 12, 2026 06:08
PleasePrompto
added a commit
that referenced
this pull request
Jul 12, 2026
- remove cleanup_old (no production caller; superseded by cleanup_finished_retention) including its tests - document the union semantics of age and count limits, add tests for age-overrides-keep_last and the disabled-limits noop - add finished_retention_hours / finished_keep_last to config.example.json and docs; note maintenance now also runs at startup Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PleasePrompto
added a commit
that referenced
this pull request
Jul 12, 2026
Post-merge fixes threading the Slack transport through main's newer subsystems (#164 per-session effort, #157 append_system_prompt_files, #166 topic-scoped kills, #137/#138 task changes): - Delete fork-only .github/workflows/upstream-release-watch.yml - Remove dead _is_message_addressed() in messenger/slack/bot.py - Fix trailing comma in config.example.json Slack section (invalid JSON) - Drop fork-only "ductor-slack" brand strings from en/wizard.toml - Harden _normalized_transport_list() in __main__.py: honor a non-empty transports list whenever the primary is a member (primary-first, others preserved) instead of collapsing to [primary] on any ordering mismatch, so telegram+matrix multi-transport setups are never silently dropped; add regression tests - named.py create(): keep both reasoning_effort and key params (# noqa: PLR0913, matching the codebase convention e.g. tasks/registry.py) - Update #164 create() test stubs for the new key kwarg - mypy: guard the optional slack_bolt import behind TYPE_CHECKING/else to satisfy strict no-redef - uv lock: add slack-bolt/slack-sdk (also picks up pre-existing lock drift) - ruff format integration-touched files Note: orch._sessions.list_active_for_chat() in slack/bot.py follows the existing private-access convention (telegram/startup.py does the same); no public accessor exists. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic retention cleanup for finished background tasks.
Why
Finished task entries (
done,failed,cancelled) were retained indefinitely unless a user manually pressed cleanup in/tasks. Since each entry persists the fulloriginal_prompt, old finished tasks can maketasks.jsongrow without bound.Changes
tasks.finished_retention_hourswith a default of 168 hours.tasks.finished_keep_lastwith a default of 100 finished tasks.runningandwaitingtasks protected from retention cleanup.Validation
uv run pytest tests/tasks tests/test_config.py tests/config -quv run ruff check ductor_bot/config.py ductor_bot/tasks/registry.py ductor_bot/tasks/hub.py tests/tasks/test_registry.py tests/tasks/test_hub.pyuv run mypy ductor_bot