fix: cross-platform plugin registry scan#14
Merged
Conversation
Add PlatformUtils::pluginExtension() to return the correct shared library extension for the current platform (.so, .dll, .dylib). Update plugin registry scan to use this helper instead of hardcoding ".so". This enables the plugin loader to find plugins on Windows and macOS.
pabloinigoblasco
added a commit
that referenced
this pull request
Mar 26, 2026
Integrate cross-platform plugin extension from PR #14 into smart reload logic. Use PlatformUtils::pluginExtension() instead of hardcoded ".so" extension.
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformUtils::pluginExtension()to return the correct shared library extension for the current platform.soProblem
The plugin registry was hardcoded to scan for
.sofiles only, which works on Linux but fails on Windows (.dll) and macOS (.dylib).Solution
Add a cross-platform helper that returns the correct extension based on compile-time platform detection:
.so.dll.dylibTest plan
./build.sh --debug && ./test.sh— all tests pass.dllextension are discovered.dylibextension are discovered