feat(dialog_sdk): add keyboard shortcut support for QPushButton#33
Merged
Merged
Conversation
Add WidgetData::setShortcut() so plugins can declaratively bind keyboard shortcuts to buttons. The host materializes them as QShortcut objects that trigger click() synchronously through the normal event pipeline. New API surface: - WidgetData::setShortcut(name, key_sequence) - WidgetDataView::shortcut(name) - installButtonShortcuts(root, view) in widget_binding
3 tasks
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
WidgetData::setShortcut()so plugins can declaratively bind keyboard shortcuts to buttons. The host materializes them asQShortcutobjects that triggerclick()synchronously through the normal event pipeline.New API surface:
WidgetData::setShortcut(name, key_sequence)— declare a shortcut for a buttonWidgetDataView::shortcut(name)— read shortcut from widget datainstallButtonShortcuts(root, view)— host-side helper to create QShortcut objectsUse Case
This enables plugins to provide keyboard shortcuts for common actions without Qt dependencies. For example, a file loader dialog could bind Ctrl+A to "Select All" and Ctrl+Shift+A to "Deselect All".
Test Plan