fix(proto_app): call applyPendingInstalls() on startup#34
Merged
Conversation
applyPendingInstalls() was never being invoked during ExtensionManager initialization, so pending plugin installs were silently ignored. Also remove a duplicate ExtensionManager construction that was shadowing the original instance.
Collaborator
Author
|
This was something already done previously but at some point it was lost during the merge of the prs, maybe in some merge |
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyPendingInstalls()was never being invoked duringExtensionManagerinitialization, so pending plugin installs were silently ignored.Also remove a duplicate
ExtensionManagerconstruction that was shadowing the original instance.Problem
When users installed plugins through the marketplace, the installation was marked as "pending" but never actually applied on subsequent app launches.
Fix
Call
applyPendingInstalls()during initialization to process any pending installs before the extension manager is used.Test Plan