feat: add code editor widget support to dialog SDK#43
Merged
Conversation
Extends the Dialog SDK with a QPlainTextEdit code editor mode: Contents: - WidgetData::setCodeContent() / setCodeLanguage() to configure a code editor - WidgetDataView::codeContent() / codeLanguage() accessors on the host side - DialogPluginTyped::onCodeChanged() virtual for typed event dispatch - WidgetEvent::codeChanged() and WidgetEventBuilder::codeChanged() for the event layer - LuaSyntaxHighlighter (lua_syntax_highlighter.hpp) applied automatically when language is "lua" - widget_binding.cpp: QPlainTextEdit detects code_content key and enters editor mode, wiring textChanged to codeChanged events only when the language property is set
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 13, 2026
Remove setCodeContent, setCodeLanguage, codeContent and codeLanguage from this branch — they were accidentally included from the source commit but belong to the code editor PR (#43), not the chart color PR.
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 14, 2026
) * feat(dialog-sdk): add per-series color and interactive chart legend Extend ChartSeries with an optional color field (hex "#rrggbb") that overrides the Qt Charts theme color for individual series. When set, the ChartPreviewWidget applies a QPen with the specified color after addSeries so the theme assignment does not win. Add an interactive legend to ChartPreviewWidget: clicking a legend marker toggles the corresponding series visibility (with faded label when hidden). Define the matplotlib tab10 10-color palette for consistent default colors across chart instances. * fix: remove code editor methods that belong to a different PR Remove setCodeContent, setCodeLanguage, codeContent and codeLanguage from this branch — they were accidentally included from the source commit but belong to the code editor PR (#43), not the chart color PR.
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 15, 2026
Sync from GitHub development: - PR #43: feat(dialog_sdk): add code editor widget support - PR #46: refactor(manifest): enforce array type for encoding field - PR #50: fix(dialog-sdk): wire buttonBox for QDialog roots # Conflicts: # pj_plugins/dialog_protocol/include/pj_plugins/host/widget_event_builder.hpp # pj_plugins/dialog_protocol/include/pj_plugins/sdk/dialog_plugin_typed.hpp # pj_plugins/dialog_protocol/include/pj_plugins/sdk/widget_event.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QPlainTextEditconfigured viasetCodeContent()/setCodeLanguage()enters "code editor" mode with Lua syntax highlighting out-of-the-boxonCodeChanged()virtual onDialogPluginTypedsetPlainTextusage is unchanged — the code editor path is opt-in via the newcode_contentkeyTest plan
pj_plugins— no compile errorsQPlainTextEditusingsetPlainTextstill works as before (read-only display)QPlainTextEditusingsetCodeContent("editor", "lua")shows Lua syntax highlighting and firesonCodeChangedon every keystroke🤖 Generated with Claude Code