fix(dialog-sdk): wire buttonBox for QDialog roots#50
Merged
Conversation
When the plugin .ui file uses a QDialog as root widget (instead of a plain QWidget), the buttonBox accept/reject signals were not connected because the wiring code lived inside the "wrap in QDialog" branch that only runs for non-QDialog roots. Move the buttonBox connection to its own block that runs unconditionally, so Close/OK/Cancel buttons work regardless of the .ui root widget type.
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 15, 2026
Sync from GitHub development: - PR #43: feat(dialog_sdk): add code editor widget support - PR #46: refactor(manifest): enforce array type for encoding field - PR #50: fix(dialog-sdk): wire buttonBox for QDialog roots # Conflicts: # pj_plugins/dialog_protocol/include/pj_plugins/host/widget_event_builder.hpp # pj_plugins/dialog_protocol/include/pj_plugins/sdk/dialog_plugin_typed.hpp # pj_plugins/dialog_protocol/include/pj_plugins/sdk/widget_event.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.uifile usesQDialogas the root widget (instead of a plainQWidget), thebuttonBoxaccept/reject signals were not connected — Close/OK/Cancel buttons did nothingbuttonBoxconnection to its own unconditional blockTest plan
.uiroot is aQDialogwith aQDialogButtonBoxnamedbuttonBox— Close button works.uiroot is a plainQWidget— OK/Cancel still work as before