Skip to content

fix(dialog-sdk): wire buttonBox for QDialog roots #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloinigoblasco merged 1 commit into from
Apr 13, 2026
Merged

fix(dialog-sdk): wire buttonBox for QDialog roots #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pj_plugins/dialog_protocol/src/dialog_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ DialogResult DialogEngine::showDialog(QWidget* parent) {
auto* layout = new QVBoxLayout(dialog);
layout->setContentsMargins(0, 0, 0, 0);
layout->addWidget(loaded);
}

// Wire buttonBox signals — works whether the loaded widget was a QDialog
// or a plain QWidget. Needed so Close/OK/Cancel buttons function correctly.
{
auto* button_box = loaded->findChild<QDialogButtonBox*>("buttonBox");
if (button_box) {
QObject::connect(button_box, &QDialogButtonBox::accepted, dialog, &QDialog::accept);
Expand Down
Loading