Marketplace standalone#7
Merged
Merged
Conversation
Add data structures for extension metadata and installation state: - Extension: registry metadata (name, version, platforms, plugins) - InstalledExtension: local installation info (path, enabled, backup) - Platform: artifact URL and checksum per platform - ExtensionPlugin: plugin details within an extension Update CMakeLists.txt with Qt6 dependencies and main.cpp placeholder.
Add RegistryManager class that fetches and parses the extension registry JSON from a remote URL. Features: - Async HTTP fetch using QNetworkAccessManager - JSON parsing with validation for mandatory/optional fields - Signal-based notification (fetchStarted, fetchFinished, fetchError) - Extension lookup by ID Contents: - src/core/RegistryManager.h - Class declaration - src/core/RegistryManager.cpp - Implementation - Updated CMakeLists.txt with marketplace_core library
- Added a mock HTTP server to simulate registry downloads. - Verified JSON parsing for mandatory and optional fields. - Validated signal emission (fetchStarted, fetchFinished, fetchError). - Added edge cases for malformed JSON and network connection issues.
Add core infrastructure for extension installation pipeline: DownloadManager: - Async download with progress tracking - SHA-256 checksum verification - In-memory ZIP extraction to destination directory - Cancellation support for in-progress operations ExtensionManager (interface only): - Header defining the orchestration layer for install/uninstall/update - Dependency injection ready (DownloadManager, ZipExtractor) - Signal-based progress and error reporting Contents: - pj_marketplace/src/core/DownloadManager.h - pj_marketplace/src/core/DownloadManager.cpp - pj_marketplace/src/core/ExtensionManager.h - pj_marketplace/tests/download_manager_test.cpp
…taging Add full install/uninstall/update lifecycle for marketplace extensions. Key features: - ExtensionManager: orchestrates download, extraction, and state persistence - PlatformUtils: cross-platform path resolution and OS detection - Windows staging: extracts to .pending/ directory when DLLs are in use - Disk space validation before extraction begins - Standalone CMake build support with LibArchive dependency The extension manager delegates download+checksum+extraction to DownloadManager and handles platform-specific behavior transparently. Contents: - src/core/ExtensionManager.cpp/.h - src/core/PlatformUtils.cpp/.h - CMakeLists.txt (standalone build, LibArchive) - conanfile.txt (LibArchive dependency)
Add build infrastructure for standalone compilation of pj_marketplace. Contents: - build.sh: standalone build script (./build.sh or ./build.sh --debug) - README.md: build instructions and project structure - conanfile.txt: Qt6, libarchive, and GTest dependencies via Conan
Remove deprecated ABI version field from requirements and specification documents as this concept is no longer part of the marketplace design.
Add unit tests covering: - Extension installation and uninstallation - State persistence and recovery - Update workflows - Error handling scenarios
feat(marketplace): add DownloadManager and ExtensionManager interface
Add new functional requirements: - F-24: Configurable registry URL in settings - F-25: Registry URL validation
docs(requirements): add F-24/F-25 and registry URL settings feature
…ialog Implements the main marketplace UI components: - MarketplaceWindow: browsable list of available extensions with filtering - ExtensionDetailDialog: detailed view for individual extension info - Mock implementations for DownloadManager, ExtensionManager, and RegistryManager to support UI development and testing The UI integrates with the existing core managers and provides a clean user experience for browsing, installing, and managing PlotJuggler extensions.
850222d to
a2d093b
Compare
- Add "Update All" button to update pending extensions in one click - Fix ZIP wrapper folder stripping on extension extraction (GitHub releases add wrapper) - Refactor DownloadManager with cleaner method signatures From internal MR !37
From internal MR !38
…ture From internal MR !33
…plementation From internal MR !39
… loss From internal MR !27
- Scroll area background: palette(mid) for better card separation - Card border: palette(shadow) for more visible boundaries - Text colors: palette(text) for version and description readability
…ambda Move installPendingRestart connection to setupSignals() to prevent duplicate connections on every registry refresh.
AUTOMOC requires Qt include directories to be available when processing headers that inherit from Qt classes. Since extension_detail_dialog.hpp is now a public header including <QDialog>, pj_marketplace_ui needs to explicitly link Qt6::Widgets.
- main.cpp: include marketplace.hpp instead of marketplace_window.hpp to get full class definitions (not just forward declarations) - CMakeLists.txt: link pj_marketplace_ui library instead of compiling UI sources directly, avoiding duplicate MOC compilation
Cherry-pick from internal_main (27a880d): - MarketplaceWindow now creates RegistryManager, DownloadManager, and ExtensionManager internally - Simplified constructor: MarketplaceWindow(registry_url) - main.cpp updated to use new constructor - Add Qt6::Widgets to pj_marketplace_ui for AUTOMOC
Tests UpdateReinstallsWithNewVersion and UpdateBacksUpOldVersionOnSuccess both use the global backupDir(). Clean up csv-loader-1.0.0 backup at the START of each test to ensure clean state regardless of previous failures.
Wrap pj_marketplace subdirectory in PJ_BUILD_DIALOG_ENGINE_QT condition to prevent build failure on platforms without Qt6 (e.g., Windows CI).
pabloinigoblasco
added a commit
that referenced
this pull request
Apr 4, 2026
Syncs internal_main with GitHub PR #7 after cherry-picking MRs !30-!46. Adds aqtinstall.log to .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standalone marketplace application for managing PlotJuggler extensions:
Test plan