feat: [MC-690] Distinct Pocket dev JWK key ids #361
Merged
+969
−808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmiermans
changed the title
mmiermans
requested review from
jpetto and
kschelonka
and removed request for
a team
jpetto
approved these changes
Feb 15, 2024
mmiermans
requested review from
katerinachinnappan
and removed request for
kschelonka
Possibly admin-api can't find the key id when it's not cached..? Locally it works fine, but on Pocket-Dev the following error occurs for the same request: Context creation failed: Could not validate User: secret or public key must be provided
I pulled the latest image from Pocket-Dev and it's set to production # echo $NODE_ENV production
Required 'Lint Code Base' failed to run.
mmiermans
commented
Feb 20, 2024
| ], | ||
| envVars: [ | ||
| { | ||
| name: 'ENVIRONMENT', |
Contributor
Author
There was a problem hiding this comment.
I checked that ENVIRONMENT was not used by searching the codebase.
mmiermans
commented
Feb 20, 2024
| return jwksClient({ | ||
| jwksUri, | ||
| cache: true, // Default Value | ||
| cacheMaxEntries: 5, // Default value |
Contributor
Author
There was a problem hiding this comment.
We increased the number of keys. Increasing cacheMaxEntries might prevent performance issues, if we have more than 5 keys. The number 100 was chosen arbitrarily.
mmiermans
added a commit
that referenced
this pull request
Feb 21, 2024
Error: When a manual configuration is not provided, gateway requires an Apollo configuration. Local development should use NODE_END=local since #361
mmiermans
added a commit
that referenced
this pull request
Feb 22, 2024
Error: When a manual configuration is not provided, gateway requires an Apollo configuration. Local development should use NODE_END=local since #361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Use different jwk keys in development and production for the Content team's Pocket JWKs.
What changed
--elv2-license acceptto start:dev script.NODE_ENVto 'development' in Pocket-Dev. Previously it was set to 'production'. 😕Implementation Decisions
References
JIRA ticket:
dotcom-gateway PR: