Release 3.2.3 · Pogut/refactoringminer-action-extension

RefactoringMiner Extension v3.2.3

A release focused on one theme: making a selected refactoring reachable no matter where GitHub has hidden it. This rolls up v3.2.2, which was not released separately.

Fixed: parts of a refactoring stayed dark behind folded context

RefactoringMiner regularly points at lines GitHub considers untouched. An Encapsulate Attribute, for example, is about the attribute it wraps, but GitHub sees that line as unchanged and folds it away behind the little blue arrow in the gutter, showing only a few lines of context around the edit itself.

The result was a refactoring that lit up in pieces. The added getter would highlight, while the attribute it was created for sat inside the fold and never lit up at all, with nothing on screen to say anything was missing.

Selecting a refactoring now opens what GitHub folded away:

The extension finds the specific fold hiding each line and clicks GitHub's own unfold control, stepping through longer folds until the line appears.
A selection now tracks every line the refactoring touches, on both sides of the diff, rather than a single representative line. Previously, if that one line happened to be visible, nothing was ever unfolded.
Freshly revealed lines are highlighted straight away, so the whole refactoring lights up together on the first blink.

Fixed: refactorings inside files marked "Viewed" were unreachable

Ticking Viewed collapses a file, and a reviewer part-way through a pull request has most of them collapsed. Clicking a refactoring that lived in one of those files did nothing useful, and with every file viewed the refactorings panel stopped responding altogether.

There were two causes wearing the same symptom. On the classic diff a collapsed file keeps all of its rows, just hidden, so the extension happily highlighted lines nobody could see. On the newer Preview diff the rows are not rendered at all, so the file could not even be located.

Clicking a refactoring now opens the file it lives in:

Collapsed files are identified and expanded before the refactoring is selected, on both diff layouts.
Your review progress is left alone. The file expands and stays ticked as Viewed. The extension never unticks it, because that state is your record of how far through a review you are.

Built on GitHub's own controls

Both fixes work by driving the same buttons you would click yourself, the unfold arrows and the file chevron, rather than calling GitHub's internal endpoints. That keeps them working when GitHub changes those endpoints, and it means no additional permissions or access tokens are needed. The permission footprint is unchanged from v3.2.1.