Using Eigen functions in Moment of intertia#3560
Using Eigen functions in Moment of intertia#3560kunaltyagi wants to merge 10 commits intoPointCloudLibrary:masterfrom
Conversation
kunaltyagi
force-pushed
the
moment_of_intertia-fix
branch
from
241e2cb to
c8f25e0
Compare
|
Added 2 more commits failing tests |
kunaltyagi
force-pushed
the
moment_of_intertia-fix
branch
2 times, most recently
from
f39a087 to
aaf22b3
Compare
kunaltyagi
force-pushed
the
moment_of_intertia-fix
branch
from
aaf22b3 to
79d4640
Compare
kunaltyagi
force-pushed
the
moment_of_intertia-fix
branch
from
514c9fe to
96af519
Compare
kunaltyagi
force-pushed
the
moment_of_intertia-fix
branch
from
96af519 to
8ecbd58
Compare
|
BTW can I get some eyes on the spin, moment_of_intertia and brisk code to tell me where I'm getting it wrong. I think I give up 😆 |
features/include/pcl/features/impl/moment_of_inertia_estimation.hpp
Outdated
Show resolved
Hide resolved
| */ | ||
| Eigen::ArrayXXd | ||
| computeSiForPoint (int index) const; | ||
| template <int Storage = Eigen::ColMajor> auto |
There was a problem hiding this comment.
What is the reason to use trailing return type here?
There was a problem hiding this comment.
The type is a bit too long and I was planning on adding something like template <Storage> auto /*Eigen::ArrayXXd<Storage>*/ for readability if this worked.
|
Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this. |
|
|
||
| if (size_list_[scale] < size) | ||
| size_list_[scale] = size; | ||
| size_list_[scale] = std::min(size_list_[scale], size); |
There was a problem hiding this comment.
This line causes 1 failure. See separate branch without this line and passing tests. Ideas why this line causes the error?
There was a problem hiding this comment.
|
Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this. |
3 participants
Separating out since it failed tests and I couldn't debug the issue.
Created a PR to keep it on my todo list