Update cmake to 3.10 and add CUDA language support#4619
Merged
kunaltyagi merged 14 commits intoPointCloudLibrary:masterfrom Aug 5, 2021
Merged
Update cmake to 3.10 and add CUDA language support#4619kunaltyagi merged 14 commits intoPointCloudLibrary:masterfrom
kunaltyagi merged 14 commits intoPointCloudLibrary:masterfrom
Conversation
larshg
force-pushed
the
UpdateCmake
branch
18 times, most recently
from
8090952 to
ee10594
Compare
kunaltyagi
reviewed
Feb 27, 2021
Contributor
Author
|
@kunaltyagi do you have any idea why 18.04 fail to find cuda.h file? Currently booting up a virtual to do some more intense debugging locally. |
Member
|
Sorry, not on top of my head. |
larshg
force-pushed
the
UpdateCmake
branch
9 times, most recently
from
b618316 to
f9a8229
Compare
This was referenced May 17, 2021
Closed
Move /bigobj as it was added to cuda targets. FindOpenMP is added due to bug in earlier version, see https://gitlab.kitware.com/cmake/cmake/-/issues/20364 Added workaround for Qt poluting with -fPIC - see https://gitlab.kitware.com/cmake/cmake/-/issues/16915
Clang can be added later.
kunaltyagi
approved these changes
Jun 25, 2021
|
Hi, @mvieth, could you review this MR? |
mvieth
approved these changes
Aug 4, 2021
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
Looks good to me, as far as my CMake and CUDA knowledge goes 😄
Member
|
@larshg merge? |
Contributor
Author
|
Let it fly 🚀 |
This was referenced Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump to 3.10
Use CUDA first language support.