NormalSpaceSampling filter: add constructor to specify extract_removed_indices #4846
Merged
kunaltyagi merged 2 commits intoPointCloudLibrary:masterfrom Aug 3, 2021
Merged
Conversation
Contributor
|
Can't you avoid the ABI break by simply adding another constructor taking the |
Member
Author
You mean like this? I suppose that should work. Thanks for the suggestion! |
Contributor
|
Yeah, exactly like this :) |
kunaltyagi
approved these changes
Jul 16, 2021
kunaltyagi
added
the
changelog: enhancement
kunaltyagi
changed the title
extract_removed_indices
larshg
approved these changes
Aug 2, 2021
mvieth
added a commit
to mvieth/pcl
that referenced
this pull request
Dec 27, 2021
…ed_indices` (PointCloudLibrary#4846) * NormalSpaceSampling filter: add parameter to constructor * Re-adding empty ctor and marking new ctor as explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2157
ABI break (correct me if I am wrong), so for PCL 1.13.0