Add more configuration options to GRSDEstimation#4852
Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom Dec 22, 2021
Merged
Add more configuration options to GRSDEstimation#4852mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
- Add functions to optionally specify nr_subdiv and plane_radius of the underlying RSDEstimation - Properly initialize width_ with 0.0 - The search radius of RSDEstimation was set as the maximum of search_radius_ and std::sqrt (3.0) * width_ / 2. However, width_ and search_radius are always the same (see setRadiusSearch in grsd.h), so it was possible to simplify this expression.
mvieth
added
changelog: ABI break
kunaltyagi
previously approved these changes
Jul 17, 2021
kunaltyagi
added
the
changelog: enhancement
kunaltyagi
approved these changes
Jul 17, 2021
larshg
approved these changes
Aug 6, 2021
themightyoarfish
pushed a commit
to themightyoarfish/pcl
that referenced
this pull request
Jan 5, 2022
) * Add more configuration options to GRSDEstimation - Add functions to optionally specify nr_subdiv and plane_radius of the underlying RSDEstimation - Properly initialize width_ with 0.0 - The search radius of RSDEstimation was set as the maximum of search_radius_ and std::sqrt (3.0) * width_ / 2. However, width_ and search_radius are always the same (see setRadiusSearch in grsd.h), so it was possible to simplify this expression. * Use inline data member initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::sqrt (3.0) * width_ / 2. However, width_ and search_radius are always the same (see setRadiusSearch in grsd.h), so it was possible to simplify this expression.Fixes #2140