wrap QMatrix in namespace pcl to resolve linker conflict with Qt6#4858
wrap QMatrix in namespace pcl to resolve linker conflict with Qt6#4858kunaltyagi merged 1 commit intoPointCloudLibrary:masterfrom
Conversation
|
Need to fix format to clang style, see here for required changes https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=19641&view=logs&jobId=84ba2080-ade3-55e3-f209-94ce73f9d406&j=84ba2080-ade3-55e3-f209-94ce73f9d406&t=9838d42f-a715-5615-242f-7e73bf03078b Click show diff. |
fixes conflict with QtGui
kunaltyagi
left a comment
There was a problem hiding this comment.
Probably also wrap the Kernel class 😆
|
@kunaltyagi Why is this flagged ABI break? |
|
Yeah, I also thought there would be no ABI break, however, the tooling used (.github/generate_abi_reports.sh) verified the following:
This would not have resulted in ill-formed programs post linkage. since this is a cpp file, the chances of someone actually relying on this are minimal and would require the person to be personally compiling PCL. Hence the decision to flag as ABI break for those people, but still send it in a minor release |
|
Here is the full report for the ml module: |
fixes conflict with QtGui
fixes conflict with QtGui. Resolves #4857