Skip to content

Add deprecation for filter getters with bool reference#4861

Merged
kunaltyagi merged 1 commit intoPointCloudLibrary:masterfrom
tin1254:add_ref_getter_deprecation
Jul 27, 2021
Merged

Add deprecation for filter getters with bool reference#4861
kunaltyagi merged 1 commit intoPointCloudLibrary:masterfrom
tin1254:add_ref_getter_deprecation

Conversation

@tin1254
Copy link
Contributor

@tin1254 tin1254 commented Jul 25, 2021

Discussed in #4828 (comment)

Deprecation is added in pcl_cuda::filter and pcl::VoxelGrid

mvieth
mvieth reviewed Jul 25, 2021
View reviewed changes
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions should stay until 1.16, not 1.15. It was 1.15 before the 1.12 release, so now (after the 1.12 release) it should be 1.16

@tin1254 tin1254 force-pushed the add_ref_getter_deprecation branch from 66cc449 to e055226 Compare July 25, 2021 20:32
@tin1254 tin1254 requested a review from mvieth July 25, 2021 21:24
@kunaltyagi kunaltyagi added changelog: deprecation Meta-information for changelog generation module: cuda module: filters labels Jul 27, 2021
@kunaltyagi
Copy link
Member

kunaltyagi commented Jul 27, 2021

Target 1.12.1 or 1.13?

mvieth
mvieth previously approved these changes Jul 27, 2021
View reviewed changes
@mvieth
Copy link
Member

mvieth commented Jul 27, 2021

Target 1.12.1 or 1.13?

I don't see a reason why 1.12.1 would not be possible, so 1.12.1?

@tin1254
Copy link
Contributor Author

tin1254 commented Jul 27, 2021

Target 1.12.1 or 1.13?

I don't see a reason why 1.12.1 would not be possible, so 1.12.1?

PCL_DEPRECATED(1, 12.1, ...) doesn't compile, maybe 1.13?

@tin1254 tin1254 force-pushed the add_ref_getter_deprecation branch from e055226 to 5968cf9 Compare July 27, 2021 19:22
@mvieth
Copy link
Member

mvieth commented Jul 27, 2021

Sorry for the misunderstanding: PCL_DEPRECATED(1, 16, ...) was correct. We want to give everyone enough time to switch to the other function before removing this function.
The question about 1.12.1 or 1.13 was, whether we merge this pull request immediately (then it would be included in the 1.12.1 release) or we merge it after we released 1.12.1, then it would be included in the 1.13.0 release. One reason why we don't merge some pull requests immediately is because we want to keep 1.12.0 and 1.12.1 ABI and API compatible. Adding a deprecation warning and documentation breaks neither ABI nor API, so I think this can be merged right after everyone approves.
Please undo your most recent changes, sorry again for the misleading formulation.

@tin1254
Add deprecation for filter getters with bool ref
d6444d6 
* Deprecate in 1.16

* Add missing documentation
@tin1254 tin1254 force-pushed the add_ref_getter_deprecation branch from 5968cf9 to d6444d6 Compare July 27, 2021 19:37
@tin1254
Copy link
Contributor Author

tin1254 commented Jul 27, 2021 •
edited
Loading

The changes were reverted now. Thanks for clarifying it, I'm not so familiar with the releasing procedure 😅

@kunaltyagi kunaltyagi added this to the pcl-1.12.1 milestone Jul 27, 2021
@kunaltyagi kunaltyagi merged commit 39b2a2e into PointCloudLibrary:master Jul 27, 2021
@tin1254 tin1254 deleted the add_ref_getter_deprecation branch July 28, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kunaltyagi kunaltyagi kunaltyagi approved these changes

@mvieth mvieth mvieth left review comments

Assignees

No one assigned

Labels

changelog: deprecation Meta-information for changelog generation module: cuda module: filters

Projects

None yet

Milestone

pcl-1.12.1

Development

Successfully merging this pull request may close these issues.

3 participants

@tin1254 @kunaltyagi @mvieth