Bugfix: Number of OpenMP threads was not validated, ...#4863
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Jul 27, 2021
MK-3PP:master
Merged
Bugfix: Number of OpenMP threads was not validated, ...#4863mvieth merged 1 commit intoPointCloudLibrary:masterfrom MK-3PP:master
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
MK-3PP:master
Conversation
…ser Error 1001: argument to num_threads clause must be positive" if number of threads was 0. According to documentation, 0 should be "auto". Added input validation to getBoundaryPoints method, treating 0 as "auto" (example taken from normal_3d_omp.hpp). Method is also used in class constructor to validate initialization value of the threads_ member, adhering to the DRY principle.
kunaltyagi
added
changelog: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
causing OpenMP User Error 1001: argument to num_threads clause must be positive" if number of threads was 0. (Issue #4860)
According to documentation, 0 should be "auto".
Added input validation to getBoundaryPoints method, treating 0 as "auto" (example taken from normal_3d_omp.hpp). Method is also used in class constructor to validate initialization value of the threads_ member, adhering to the DRY principle.