Fix SampleConsensusModelCylinder.projectPoints and verify with test#4881
Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom Aug 8, 2021
Merged
Fix SampleConsensusModelCylinder.projectPoints and verify with test#4881mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
The last component of dir must be zero to make the normalization work correctly.
mvieth
added
module: sample_consensus
changelog: fix
kunaltyagi
approved these changes
Aug 8, 2021
larshg
approved these changes
Aug 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3876
Closes #3975 . That pull request does not contain a test, changes more than necessary, and has an indexing error while accessing
projected_points.