fix: max_id size should be equal to histogram.size() - 1#4934
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Sep 5, 2021
Merged
fix: max_id size should be equal to histogram.size() - 1#4934mvieth merged 1 commit intoPointCloudLibrary:masterfrom
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
Conversation
larshg
approved these changes
Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in common/feature_histogram.cpp :
the function is
getMeanValue(). you want to get max_id in histogram so you pick the size of histogram.Actually I guess you want the value
histogram.size() - 1to be the max index.so I start an issue for discuss then get your reply.
The issue url is: #4920