Skip to content

Fix division by 0 width in PointCloud structured assign #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvieth merged 2 commits into from
Jan 2, 2022
Merged

Fix division by 0 width in PointCloud structured assign #5113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0269d0
Check for width in assign().
vcarpani Dec 30, 2021
e1704e2
Update common/include/pcl/point_cloud.h
vcarpani Jan 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/include/pcl/point_cloud.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,12 @@ namespace pcl
inline void
assign(InputIterator first, InputIterator last, index_t new_width)
{
if (new_width == 0) {
PCL_WARN("Assignment with new_width equal to 0,"
"setting width to size of the cloud and height to 1\n");
return assign(std::move(first), std::move(last));
}

points.assign(std::move(first), std::move(last));
width = new_width;
height = size() / width;
Expand Down Expand Up @@ -631,6 +637,11 @@ namespace pcl
void
inline assign(std::initializer_list<PointT> ilist, index_t new_width)
{
if (new_width == 0) {
PCL_WARN("Assignment with new_width equal to 0,"
"setting width to size of the cloud and height to 1\n");
return assign(std::move(ilist));
}
points.assign(std::move(ilist));
width = new_width;
height = size() / width;
Expand Down