Skip to content

[filters] add PCL_ALIGNED_OPERATOR_NEW to classes with Eigen::Vector4 members#5125

Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
themightyoarfish:add-missing-aligned-operators
Jan 9, 2022
Merged

[filters] add PCL_ALIGNED_OPERATOR_NEW to classes with Eigen::Vector4 members#5125
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
themightyoarfish:add-missing-aligned-operators

Conversation

@themightyoarfish
Copy link
Copy Markdown
Contributor

Looked at all filters headers. Some have 4-element eigen types as members and thus require aligned operators new.

@themightyoarfish
Copy link
Copy Markdown
Contributor Author

@mvieth I rewrote #5116 and this time looked only for Vector4. members. Found 4 classes that were seemingly missing the operator.

Copy link
Copy Markdown
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mvieth mvieth merged commit 8565c1a into PointCloudLibrary:master Jan 9, 2022
@themightyoarfish themightyoarfish changed the title [filters] add PCL_ALIGNED_OPERATOR_NEW to classes Eigen::Vector4 members [filters] add PCL_ALIGNED_OPERATOR_NEW to classes with Eigen::Vector4 members Jan 12, 2022
@themightyoarfish themightyoarfish deleted the add-missing-aligned-operators branch November 3, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants