Change static to const since it-stability is not guaranteed#5147
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Jan 31, 2022
Merged
Change static to const since it-stability is not guaranteed#5147mvieth merged 1 commit intoPointCloudLibrary:masterfrom
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
Conversation
mvieth
approved these changes
Jan 30, 2022
Member
mvieth
left a comment
There was a problem hiding this comment.
Thanks!
Regarding the space after find: We are slowly enforcing uniform formatting via clang-format, module-by-module. For visualization, formatting is not enforced yet, but the formatting rules say that there should not be a space between function name and parentheses. So deleting it is perfectly fine 🙂
larshg
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
pcl::visualization::PCLVisualizer::resetCameraViewpointan iterator of astd::unordered_mapwas saved in a static variable, even though it might get invalidated when rehashing occurs (see https://en.cppreference.com/w/cpp/container/unordered_map ).The function also always uses the first
idit was ever passed, essentially ignoring the param after the first call.(NOTE: I am not sure, if the space between find and parantheses was intentional. If yes, I'll recreate it)