Fix wrong header when saving PolygonMesh to ply file#5169
Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom Feb 17, 2022
Merged
Fix wrong header when saving PolygonMesh to ply file#5169mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
…onMesh Previously, the fields in the header had a fixed order: x, y, z, red, green, blue, alpha, nx, ny, nz, curvature. In the body however, the values were written in the order in which they actually occurred in the given PolygonMesh. If that was not the same order as in the header, the written PLY file was wrong. Now, the header also uses the order specified in the given PolygonMesh. Other (minor) changes: - Avoid duplicated code (for writing the header), put it in a shared function instead - Remove variable `c`, it is always 0 - Use more range-for-loops
larshg
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3251
Fixes #3246
Please also see commit messages for details.