Skip to content

Add new CI to cover uncommon configurations, running weekly#5208

Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
mvieth:ubuntu-variety
Apr 3, 2022
Merged

Add new CI to cover uncommon configurations, running weekly#5208
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
mvieth:ubuntu-variety

Conversation

@mvieth
Copy link
Copy Markdown
Member

@mvieth mvieth commented Mar 20, 2022

See issue #5101
If you prefer a name other than "Ubuntu variety", feel free to make suggestions.

@mvieth mvieth added changelog: new feature Meta-information for changelog generation module: ci labels Mar 20, 2022
@mvieth mvieth force-pushed the ubuntu-variety branch 2 times, most recently from ff9a775 to 3c99aef Compare March 21, 2022 13:56
@mvieth mvieth marked this pull request as ready for review March 21, 2022 20:15
@mvieth mvieth requested review from kunaltyagi and larshg March 27, 2022 09:42
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Mar 27, 2022

Is it run whenever there is changes to master and every Saturday?
Or is it only master when changes in the paths specified?

It looks nice🥳

And the todo's can be added/adjusted after a test period?
Ie. other dependencies and tutorials.

@mvieth
Copy link
Copy Markdown
Member Author

mvieth commented Mar 27, 2022

Is it run whenever there is changes to master and every Saturday? Or is it only master when changes in the paths specified?

It is the same behaviour as the Docker build: it runs every Saturday, and when there are changes in the paths (master branch and prs)

It looks nice:partying_face:

Thanks 😄

And the todo's can be added/adjusted after a test period? Ie. other dependencies and tutorials.

Yes exactly. I think the most important stuff is already covered (different compilers, C++ standards, build types, ...), but there is of course a lot more we can test. I think it is worth to already have this basic version running soon, instead of trying to implement all possible ideas in this PR

@mvieth mvieth merged commit daf5a3d into PointCloudLibrary:master Apr 3, 2022
@mvieth mvieth deleted the ubuntu-variety branch April 3, 2022 11:54
Copy link
Copy Markdown

@Hanooona Hanooona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: new feature Meta-information for changelog generation module: ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants