Added PointCloudXYZHSVtoXYZRGB function#5220
Merged
mvieth merged 3 commits intoPointCloudLibrary:masterfrom Apr 9, 2022
Merged
Added PointCloudXYZHSVtoXYZRGB function#5220mvieth merged 3 commits intoPointCloudLibrary:masterfrom
mvieth merged 3 commits intoPointCloudLibrary:masterfrom
Conversation
I don't why this function had not been added before, maybe im wrong idk.
|
I would love this pull request to be checked and accepted as it is a funcionality that I would like to use in my 3D Vision Robot with RPI4B project. Thank you |
mvieth
reviewed
Apr 8, 2022
Sorry about that, I have now fixed the documentation of the PointCloudXYZRGBtoXYZI which I messed up and updated the documentation for the PointCloudXYZHSVtoXYZRGB function I created. G.
Also, without any intention of harming, I wanted to slightly point you out a small gramatical error on this text. 'had not been' is incorrect. Means nothing. The correct expression would be 'has not been added'. Don't worry, live and learn from mistakes! LM |
larshg
reviewed
Apr 8, 2022
As mvieth mentioned, it works the same way as before only removing .point field from all variables in the loops.
mvieth
approved these changes
Apr 9, 2022
larshg
approved these changes
Apr 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why this function had not been added before.
PointXYZRGBtoXYZHSV is there but PointCloudXYZHSVtoXYZRGB is not so i created one.
Based in PointCloudXYZRGBtoXYZHSV function.