[sample_consensus] Fix inconsistent sample validation#5270
Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom Jun 11, 2022
Merged
Conversation
Contributor
Author
mvieth
reviewed
May 23, 2022
mvieth
reviewed
May 25, 2022
alexvorndran
commented
May 26, 2022
mvieth
reviewed
May 28, 2022
alexvorndran
force-pushed
the
sample_consensus-sample-validation
branch
from
5dc4ec0 to
79bf3f8
Compare
mvieth
reviewed
Jun 3, 2022
The changes address the following models: - SampleConsensusModelLine - SampleConsensusModelCone - SampleConsensusModelCylinder - SampleConsensusModelPlane - SampleConsensusModelCircle2D - SampleConsensusModelCircle3D SampleConsensusModelStick is not adressed, since it's currently broken beyond the scope of this PR (see #2452).
Special emphasis is placed on tests with collinear inputs.
alexvorndran
force-pushed
the
sample_consensus-sample-validation
branch
from
79bf3f8 to
8185eb0
Compare
mvieth
reviewed
Jun 4, 2022
mvieth
approved these changes
Jun 5, 2022
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
I will wait a few more days before merging, in case someone else wants to have a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address inconsistencies in sample validation of
SampleConsensusModelStick→ might better be part of a fix for Improve documentation and implementation of SampleConsensusModelStick #2452Resolves #5268.