Skip to content

[visualization] add Scalar template variable to RegistrationVisualizer#5290

Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
keineahnung2345:reg_vis_scalar
Jun 9, 2022
Merged

[visualization] add Scalar template variable to RegistrationVisualizer#5290
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
keineahnung2345:reg_vis_scalar

Conversation

@keineahnung2345
Copy link
Copy Markdown
Contributor

No description provided.

@mvieth
Copy link
Copy Markdown
Member

mvieth commented Jun 8, 2022

Would you explain a bit more what these changes are for? Was it previously not possible to use the visualizer with all registration classes?

@keineahnung2345
Copy link
Copy Markdown
Contributor Author

After add Scalar template variable to NormalDistributionsTransform, I tried to use it as NormalDistributionsTransform<PointSource, PointTarget, double> with RegistrationVisualizer, and it failed at setRegistration (pcl::Registration<PointSource, PointTarget> &registration). So I realized that RegistrationVisualizer should also have a Scalar template variable to make it compilable.

Copy link
Copy Markdown
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mvieth mvieth added changelog: enhancement Meta-information for changelog generation module: registration labels Jun 8, 2022
@mvieth mvieth merged commit 4b44139 into PointCloudLibrary:master Jun 9, 2022
@keineahnung2345 keineahnung2345 deleted the reg_vis_scalar branch June 9, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants