[feat] add Scalar template variable to GeneralizedIterativeClosestPoint#5312
Merged
mvieth merged 4 commits intoPointCloudLibrary:masterfrom Jul 28, 2022
Merged
[feat] add Scalar template variable to GeneralizedIterativeClosestPoint#5312mvieth merged 4 commits intoPointCloudLibrary:masterfrom
mvieth merged 4 commits intoPointCloudLibrary:masterfrom
Conversation
mvieth
reviewed
Jul 7, 2022
mvieth
added
changelog: enhancement
mvieth
approved these changes
Jul 27, 2022
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
Looks good (I am assuming that Eigen is smart enough to optimize the cast<float>() functions away if asked to convert float to float)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.