Fixes Crash in pcl::PLYReader::amendProperty#5331
Merged
mvieth merged 3 commits intoPointCloudLibrary:masterfrom Jul 19, 2022
Merged
Fixes Crash in pcl::PLYReader::amendProperty#5331mvieth merged 3 commits intoPointCloudLibrary:masterfrom
mvieth merged 3 commits intoPointCloudLibrary:masterfrom
Conversation
Fixes Crash in pcl::PLYReader::amendProperty: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42111 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32184 In a `pcl::PLYReader::amendProperty` call `cloud_->fields` is empty and the `finder` iterator is invalid. It leads to invalid memory read in Release.
mvieth
reviewed
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Crash in pcl::PLYReader::amendProperty:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42111 and
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32184
In a
pcl::PLYReader::amendPropertycallcloud_->fieldsis empty and thefinderiterator is invalid. It leads to invalid memory read in Release.