Add more error handling to some PCL CMake functions#5344
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Aug 5, 2022
Merged
Conversation
SunBlack
force-pushed
the
error_handling_cmake_parse_arguments
branch
5 times, most recently
from
ad8bfe8 to
bf86cc2
Compare
- Add a fatal error in case cmake_parse_arguments contains unparsed arguments - Add a fatal error in case a parameter is required but not present
SunBlack
force-pushed
the
error_handling_cmake_parse_arguments
branch
from
bf86cc2 to
4439f96
Compare
mvieth
added
module: cmake
changelog: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake_parse_argumentscontains unparsed argumentsNote: We should generalize the call to
ARGS(cmake_parse_arguments(ARGS ...) as it seems there are some copy & paste errors there (should be a separate MR)