Combine PCL_SUBSUBSYS_DEPEND with PCL_SUBSYS_DEPEND#5387
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Aug 19, 2022
Merged
Combine PCL_SUBSUBSYS_DEPEND with PCL_SUBSYS_DEPEND#5387mvieth merged 1 commit intoPointCloudLibrary:masterfrom
PCL_SUBSUBSYS_DEPEND with PCL_SUBSYS_DEPEND#5387mvieth merged 1 commit intoPointCloudLibrary:masterfrom
Conversation
SunBlack
force-pushed
the
combine_PCL_SUBSYS_DEPEND
branch
2 times, most recently
from
df01295 to
1a1ff1c
Compare
SunBlack
force-pushed
the
combine_PCL_SUBSYS_DEPEND
branch
from
1a1ff1c to
ca53f26
Compare
larshg
approved these changes
Aug 18, 2022
Contributor
|
Can you do same exercise for PCL_(SUB)SUBSYS_OPTION also? 😃 |
Contributor
Author
Not in this PR, was not even sure if I should make the changes related to |
mvieth
added
changelog: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5379
Note: Added
NAMEas parameter as I think named parameter increases the readability.