Skip to content

[CMake] Fix issue with TARGET_PDB_FILE#5396

Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
SunBlack:fix_pdb_installation
Aug 21, 2022
Merged

[CMake] Fix issue with TARGET_PDB_FILE#5396
mvieth merged 1 commit intoPointCloudLibrary:masterfrom
SunBlack:fix_pdb_installation

Conversation

@SunBlack
Copy link
Copy Markdown
Contributor

Check for link type of specific library instead of using global PCL_SHARED_LIBS to determine if a PDB file should installed or not.

Fixes:

CMake Error:
  Error evaluating generator expression:

    $<TARGET_PDB_FILE:pcl_cc_tool_interface>

  TARGET_PDB_FILE is allowed only for targets with linker created artifacts.

Reason for this issue are these lines, so we should not rely on PCL_SHARED_LIBS, but on PCL_LIB_TYPE

set(PCL_LIB_TYPE_ORIGIN ${PCL_LIB_TYPE})
set(PCL_LIB_TYPE STATIC)
PCL_ADD_LIBRARY(pcl_cc_tool_interface COMPONENT ${SUBSUBSYS_NAME} SOURCES ${INTERFACE_HEADERS} ${INTERFACE_SOURCES})
target_link_libraries(pcl_cc_tool_interface pcl_common pcl_filters pcl_search pcl_visualization ${QTX}::Widgets)
set(PCL_LIB_TYPE ${PCL_LIB_TYPE_ORIGIN})

…HARED_LIBS to determine if a PDB file should installed or not
@mvieth mvieth added module: cmake changelog: fix Meta-information for changelog generation labels Aug 21, 2022
@mvieth mvieth merged commit 82db1ed into PointCloudLibrary:master Aug 21, 2022
@SunBlack SunBlack deleted the fix_pdb_installation branch August 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: fix Meta-information for changelog generation module: cmake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants