[CMake] Fix issue with TARGET_PDB_FILE#5396
Merged
mvieth merged 1 commit intoPointCloudLibrary:masterfrom Aug 21, 2022
Merged
Conversation
…HARED_LIBS to determine if a PDB file should installed or not
mvieth
approved these changes
Aug 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for link type of specific library instead of using global PCL_SHARED_LIBS to determine if a PDB file should installed or not.
Fixes:
Reason for this issue are these lines, so we should not rely on
PCL_SHARED_LIBS, but onPCL_LIB_TYPEpcl/apps/cloud_composer/CMakeLists.txt
Lines 73 to 81 in 6f28bcd