Skip to content

Part E of transition to support modernize-use-default-member-init#5782

Merged
mvieth merged 9 commits intoPointCloudLibrary:masterfrom
gnawme:feature/use-default-member-init-e
Aug 31, 2023
Merged

Part E of transition to support modernize-use-default-member-init#5782
mvieth merged 9 commits intoPointCloudLibrary:masterfrom
gnawme:feature/use-default-member-init-e

Conversation

@gnawme
Copy link
Copy Markdown
Contributor

@gnawme gnawme commented Aug 5, 2023

Part E of #5665 to add these checks to clang-tidy:

  • [modernize-use-default-member-init](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html)

  • [modernize-use-bool-literals](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-bool-literals.html)

@mvieth
Copy link
Copy Markdown
Member

mvieth commented Aug 8, 2023

Could you resolve the conflict, please?

@gnawme gnawme force-pushed the feature/use-default-member-init-e branch from 0c295ae to 61e3adc Compare August 8, 2023 14:02
larshg
larshg reviewed Aug 23, 2023
View reviewed changes
Comment thread features/include/pcl/features/brisk_2d.h Outdated
larshg
larshg reviewed Aug 23, 2023
View reviewed changes
Comment thread keypoints/include/pcl/keypoints/smoothed_surfaces_keypoint.h Outdated
larshg
larshg reviewed Aug 23, 2023
View reviewed changes
Comment thread ml/include/pcl/ml/dt/decision_tree_trainer.h Outdated
larshg
larshg reviewed Aug 23, 2023
View reviewed changes
Comment thread outofcore/include/pcl/outofcore/outofcore_node_data.h Outdated
larshg
larshg reviewed Aug 28, 2023
View reviewed changes
Comment thread features/include/pcl/features/brisk_2d.h Outdated
larshg
larshg reviewed Aug 28, 2023
View reviewed changes
Comment thread outofcore/include/pcl/outofcore/outofcore_node_data.h Outdated
larshg
larshg reviewed Aug 28, 2023
View reviewed changes
Comment thread ml/include/pcl/ml/impl/dt/decision_tree_trainer.hpp Outdated
larshg
larshg reviewed Aug 28, 2023
View reviewed changes
Comment thread ml/include/pcl/ml/dt/decision_tree_trainer.h Outdated
@larshg larshg requested a review from mvieth August 29, 2023 06:56
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Aug 29, 2023

Looks good, thanks 👍

mvieth
mvieth approved these changes Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvieth mvieth merged commit 969d5d3 into PointCloudLibrary:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larshg larshg larshg approved these changes

@mvieth mvieth mvieth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnawme @mvieth @larshg