Circle3D: fix optimizeModelCoefficients use an uninitialized var#6088
Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom Jul 19, 2024
Merged
Circle3D: fix optimizeModelCoefficients use an uninitialized var#6088mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
…ed a uninitialized variable
Member
|
Thanks for fixing this! I think the last three coefficients, that represent the normal direction, also need to be normalized after the minimization, like so: |
Contributor
Author
You are right, the axis is not nomalized after the minimization. This will not affect the result, but will confuse the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcl::SampleConsensusModelCircle3D::optimizeModelCoefficients use a uninitialized var as a initial guess to do the minimization. It will never get a correct answer, and the minimization will never be done. This PR fix it.