fix: Initialization with correct signedness#6111
Merged
mvieth merged 2 commits intoPointCloudLibrary:masterfrom Aug 20, 2024
Merged
fix: Initialization with correct signedness#6111mvieth merged 2 commits intoPointCloudLibrary:masterfrom
mvieth merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
mvieth
added
module: segmentation
changelog: fix
Member
|
BTW you can disregard the failing macOS Ventura 13 check. That is unrelated to your changes and will be fixed by another pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing issue 6110
#6110
Problem:
A max range of int is implicitly casted to unsigned int. This may cause an overflow and the semantic meaning of max is lost.
Simple solution: Changed the respective line and ran the tests