Add missing English effect_entries for as-one-glastrier and as-one-spectrier#1620
Open
santichausis wants to merge 1 commit into
Open
Add missing English effect_entries for as-one-glastrier and as-one-spectrier#1620santichausis wants to merge 1 commit into
santichausis wants to merge 1 commit into
Conversation
…ectrier Both abilities had zero rows in ability_prose.csv, so effect_entries was empty for them despite every other ability having at least an English entry. Fixes PokeAPI#1615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1615.
as-one-glastrier(ability 266) andas-one-spectrier(ability 267) had zero rows indata/v2/csv/ability_prose.csv, soeffect_entrieswas empty for both, unlike every other ability which has at least an English entry.Fix
Added English (
local_language_id9) rows for both abilities, describing them as the combination of Unnerve with Chilling Neigh / Grim Neigh respectively (matching the official in-game description, see Bulbapedia), and reusing the existing English wording already in this CSV for Unnerve (127), Chilling Neigh (264), and Grim Neigh (265).I only added English entries — I didn't have a reliable source for official French wording so I left that out rather than guess.
Test plan
csv.DictReaderparses the file cleanly (809 rows, no errors).GET /api/v2/ability/as-one-glastrier/→effect_entriesnow has an English entry.GET /api/v2/ability/as-one-spectrier/→ same.manage.py test pokemon_v2passes (56 tests).