fix: model Minior meteor/core forms consistently - #1632
Open
MiquelRForgeFlow wants to merge 1 commit into
Open
Conversation
Give all 14 Minior forms is_battle_only=0 and a Shields Down condition whose base_form points to the same-colour counterpart (meteor <-> core), so the shield/core toggle is represented in both directions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Follow-up of #1616)
Give all 14 Minior forms
is_battle_only=0and a Shields Down condition whosebase_formpoints to the same-colour counterpart (meteor <-> core), so the shield/core toggle is represented in both directions.All 14 Minior forms (7 Meteor + 7 Core) are marked
is_battle_only = 0, since neither is strictly battle-only: outside of battle a wild Minior appears in its Meteor form while a caught one shows its Core, so both forms can be seen outside of battle. The Shields Down toggle between them is instead captured by thetrigger_conditions, with each form'sbase_formpointing to its same-colour counterpart (Meteor ↔ Core).Which form is shown outside of battle (wild → Meteor, caught → Core) isn't something the current form model can express; it would need an extra configuration (a wild-vs-caught default form). That's out of scope here, but the same mechanism would also cover Gimmighoul (Chest vs Roaming), so it may be worth considering as a separate, follow-up feature.
AI coding assistance disclosure
Checking numbers and generating PR description.
Contributor check list