Safari Auto Catch Improvements - #1322
Merged
theastrogoth merged 6 commits intoAug 18, 2026
Merged
Conversation
Dalton-V
force-pushed
the
frlg-auto-catch-safari
branch
from
July 12, 2026 17:06
ebba2d7 to
5a8e1f5
Compare
Dalton-V
force-pushed
the
frlg-auto-catch-safari
branch
from
August 17, 2026 00:04
5a8e1f5 to
3d6ce18
Compare
Dalton-V
marked this pull request as ready for review
August 17, 2026 21:05
Contributor
|
Looks good to me! I left a couple of small comments that mention possible improvements to my own code, but I can handle those separately if you'd rather not deal with them. |
Mysticial
approved these changes
Aug 18, 2026
Mysticial
left a comment
Mysticial
left a comment
Collaborator
There was a problem hiding this comment.
Rubber stamping since I've relinquished control of the FRLG to Astro and kichi.
Astro can merge when ready.
Member
Author
|
Ope. I got the logic in auto catch crossed with safari in my update.. I didn't realize it was returning how many balls were thrown. Probably need to update the comment in the .h auto catch cause its wrong... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Union pokedex registered detectors.
Move auto_catch to Navigation
Create Safari specific auto catch method using optimal safari actions.