Skip to content

upload standalone .exe file for windows builds - #1380

Merged
jw098 merged 1 commit into
PokemonAutomation:mainfrom
jw098:ci
Aug 12, 2026
Merged

upload standalone .exe file for windows builds#1380
jw098 merged 1 commit into
PokemonAutomation:mainfrom
jw098:ci

Conversation

@jw098

@jw098 jw098 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator
  • downgraded Qt version to match our official releases. So that someone can take the standalone .exe binary and test it themselves
  • upload standalone .exe file for windows builds. I'm not sure if dropping in the standalone .exe file also works for Mac/Linux. If it does, then we could consider uploading standalone .exe files for them too.

@jw098
jw098 requested a review from pifopi August 12, 2026 05:34
if: inputs.upload-build && startsWith(inputs.os, 'windows')
with:
name: Standalone Executable (os=${{inputs.os}})
path: ${{env.UPLOAD_FOLDER}}/SerialPrograms.exe

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to reuse the full folder with needed files, etc ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question. What are you suggesting?

Are you asking why I'm uploading the standalone .exe file, in addition to the full folder?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ! The exe file is included inside the folder that is already uploaded. And it has that and many more needed files (package, dll, etc) the only missing piece is dll for qt as they are very big and users might have a newer version locally!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought was that the standalone .exe is easier to download since it's smaller. For people who already have CC downloaded, they can just drop in the standalone SerialPrograms.exe to replace the old old.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me ! It's likely they'd need up to date package though but that can be downloaded manually on the side !

@pifopi

pifopi commented Aug 12, 2026

Copy link
Copy Markdown
Member

For mac and linux, I've tried in the past. Linux was working (=booting), mac I do not think so (but could not test). Not sure it's worth the pain with Koi's CI ?

@jw098
jw098 merged commit 921da68 into PokemonAutomation:main Aug 12, 2026
7 checks passed
@jw098
jw098 deleted the ci branch August 14, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants