Skip to content

chore: update eslint and add rules#111

Merged
EndBug merged 14 commits intomainfrom
eslint
Feb 26, 2024
Merged

chore: update eslint and add rules#111
EndBug merged 14 commits intomainfrom
eslint

Conversation

@lorenzocorallo
Copy link
Copy Markdown
Member

@lorenzocorallo lorenzocorallo commented Feb 5, 2024 •
edited
Loading

  • update eslint packages to latest version
  • separate prettier from eslint (best practice: formatter and linter should be separated for performance)
  • add rules to prevent unused imports and variables
  • migrate existing code to be aligned with new rules

Note: in scripts/database.ts a lot of rules are ignored because it's actually pretty difficult to strictly-type it. In future we should consider rewriting it in a smarter way.

Also closes #112 with 317170c

@lorenzocorallo lorenzocorallo requested a review from EndBug February 5, 2024 21:10
@github-actions github-actions Bot temporarily deployed to preview February 5, 2024 21:10 Destroyed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2024 •
edited
Loading

Pages Preview
Preview removed because the pull request was closed.
2024-02-26 23:12:18 +0000

@github-actions github-actions Bot temporarily deployed to preview February 13, 2024 07:09 Destroyed
EndBug
EndBug requested changes Feb 13, 2024
View reviewed changes
Comment thread package.json
Comment thread package.json Outdated
Comment thread src/components/pages/QPreview.tsx Outdated
Comment thread src/components/Header.tsx Outdated
Comment thread src/i18n.ts Outdated
@github-actions github-actions Bot temporarily deployed to preview February 16, 2024 12:14 Destroyed
@github-actions github-actions Bot temporarily deployed to preview February 16, 2024 12:27 Destroyed
@github-actions github-actions Bot temporarily deployed to preview February 16, 2024 12:39 Destroyed
@github-actions github-actions Bot temporarily deployed to preview February 16, 2024 13:15 Destroyed
@github-actions github-actions Bot temporarily deployed to preview February 16, 2024 14:08 Destroyed
@lorenzocorallo
Copy link
Copy Markdown
Member Author

lorenzocorallo commented Feb 16, 2024

note: forced pushed from c608476 to 4b752f4 for wrong commit message

EndBug
EndBug reviewed Feb 19, 2024
View reviewed changes
Comment thread package.json
@lorenzocorallo
Copy link
Copy Markdown
Member Author

lorenzocorallo commented Feb 21, 2024

I think that all the review comments have been addressed, so we can proceed to merge.
@toto04 @toto04 all right?

@EndBug
Copy link
Copy Markdown
Member

EndBug commented Feb 21, 2024

@lorenzocorallo I haven't been able to test this locally yet, that's why the review is not approved yet. Sorry :/

EndBug
EndBug approved these changes Feb 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @lorenzocorallo, LGTM ✅
(and sorry for the long waiting time)

@EndBug EndBug enabled auto-merge (squash) February 26, 2024 23:11
@github-actions github-actions Bot temporarily deployed to preview February 26, 2024 23:11 Destroyed
@EndBug EndBug disabled auto-merge February 26, 2024 23:11
@EndBug EndBug changed the title feat: update eslint and add rules chore: update eslint and add rules Feb 26, 2024
@EndBug EndBug enabled auto-merge (squash) February 26, 2024 23:11
@EndBug EndBug merged commit b62d230 into main Feb 26, 2024
@EndBug EndBug deleted the eslint branch February 26, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toto04 toto04 toto04 left review comments

@EndBug EndBug EndBug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Node to v20

3 participants

@lorenzocorallo @EndBug @toto04