migrate to Vite#97
Merged
Merged
Conversation
- remove: react-scripts - add: vite @vitejs/plugin-react-swc eslint-plugin-react-hooks eslint-plugin-react-refresh - bump: typescript dotenv - update package.json scripts - remove assets symlink in static folder: vite does not support importing files in /public in javascript telegram_logo is moved to static logo3000 is copied to static - fix code using new typescript rules: react-hooks and react-refresh - update tsconfig referring to create-vite template - replace react-app-env.d.ts with vite-env.d.test - move /public/index.html to /index.html because of vite setup
EndBug
requested changes
May 1, 2023
- in useEffect, useState MUST be used in its extended form
e.g. WRONG -> props.viewState[1](.....)
CORRECT -> setView(....)
note: change the dependencies array accordingly
- this fixes also a related issue regarding i18n not working
Member
|
(currently waiting for the next version to be released before merging this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes listed in first commit notes
@EndBug please double-check that everything is working fine, especially workflows, deploy, db build and env variables.
Note: the high number of line changes only depends on
package-lock.jsonand, as you can see, CRA sucksCloses #96