Delete stale CRITICAL_TEMPERATURE_BUG.md#44
Merged
Conversation
This file documented a temperature-scaling bug in `HardConcrete._deterministic_gates` and pointed readers at a "gold standard" reference file `l0_louizos_improved_gate.py` that does not actually exist in the repository. The bug itself is fixed by #41 (the `sigmoid(qz_logits / temperature)` change in `l0/distributions.py`), and the three standalone modules (`distributions.py`, `calibration.py`, `sparse.py`) are now consistent. Remove the stale doc now that its content is either obsolete or misleading. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#40 switched the repo's formatter from `black -l 79` to `ruff format` (default 88-char line length) and updated the Makefile, but the reusable lint workflow still invoked `lgeiger/black-action` with `. -l 79 --check`. Since ruff-formatted files don't pass `black -l 79`, every PR's `lint` check has been failing since #40. Replace the black action with a `uvx ruff format --check .` run, matching what `make format-check` would do locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MaxGhenis
commented
Apr 17, 2026
Contributor
Author
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
LGTM — merge-first.
Scope verified:
.github/workflows/reusable_lint.yamlswapslgeiger/black-actionforuvx ruff format --check .with python 3.13 +astral-sh/setup-uv@v3setup. Matches the Makefile change from #40 and already passes CI on this PR.- No other CI config is touched (5 other workflow files untouched).
CRITICAL_TEMPERATURE_BUG.mddeletion is safe: the doc pointed at a nonexistentl0_louizos_improved_gate.py, and PR #41 applies the actual fix it described.- 2 changelog fragments added (fixed + removed). Tight scope, clean commits.
Lint + test + changelog checks all green; mergeable. Merge this first to unblock the other three PRs' lint checks.
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small housekeeping fixes bundled together:
CRITICAL_TEMPERATURE_BUG.md. The file documented a temperature-scaling bug inHardConcrete._deterministic_gatesand pointed readers atl0_louizos_improved_gate.py, a file that does not exist in the repo. The actual bug is fixed by Fix temperature scaling in HardConcrete deterministic gates #41 (thesigmoid(qz_logits / temperature)change inl0/distributions.py:132), so the three core modules (distributions.py,calibration.py,sparse.py) are now consistent.black -l 79toruff formatand updated the Makefile, but the reusable lint workflow still invokedlgeiger/black-actionwith. -l 79 --check. Since every ruff-formatted file failsblack -l 79, every PR'slintcheck has been failing since Switch code formatter from Black to Ruff #40 — including the three companion PRs in this series.Addresses bug-hunt findings
Also unblocks CI for the rest of the series (#41, #42, #43).
Depends on
lint), then Fix temperature scaling in HardConcrete deterministic gates #41, Standardize Hard Concrete numerical guards across modules #42, Export SparseCalibrationWeights and add optional seed parameter #43.Test plan
uvx ruff format --check .onorigin/mainreports21 files already formatted— the workflow change will not flag existing files.grep -R CRITICAL_TEMPERATURE_BUGandgrep -R l0_louizos_improved_gatereturn no matches after the deletion.