Review sweep: site copy, paper comparisons vs latest publications, E2E-verified#35
Merged
Conversation
…fixes Site: all pages shortened 16-18%, stale three-engine claim fixed, links verified. Papers: obr-macro 35pp (Mar-2026 EFO vintage drift, ONS outturns, multiplier literature), boe-svar 28pp (7-quarter outturn RMSE 0.32pp, 14/14 in 68% bands, Bank FER cross-check), psl-og 34pp (full OBR WP22 scenario table, DEP fit stats, OG-USA plausibility corridor), frb-us 36pp (LINVER/Hebden/Kiley, cross-model table, new cost-push experiment). ~25 referee findings fixed incl. several wrong numbers. E2E test: all six areas pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vahid-ahmadi
added a commit
that referenced
this pull request
Jul 18, 2026
The previous commit was made from a stale checkout and unintentionally reverted the workflow changes from #35. This restores all four workflow files to their state on main, leaving this branch's diff scoped to the reform-input validation in integration/. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vahid-ahmadi
added a commit
that referenced
this pull request
Jul 18, 2026
* Actionable reform-input validation for the MCP/CLI tools
Two defects found in live end-to-end testing of the hosted server:
1. Date-range reform keys ("2026-01-01.2029-12-31") surfaced a raw pydantic
dump: "unconverted data remains: .2029-12-31". Root cause is upstream:
policyengine's compile_reform parses each key with
strptime(key, "%Y-%m-%d") and builds ParameterValue(end_date=None), so a
reform value applies from its effective date and never expires. The
reform-dict API has no way to express an end date, and silently dropping
it would score a permanent reform when the caller asked for a temporary
one. Ranges are therefore rejected up front with an explanation, the
correct single-date form, and a per-year workaround -- not faked.
2. calculate_household returned a raw "2 validation errors ... Field
required" dump when country/people were omitted. The MCP arguments are
now optional at the schema level and validated in core, so callers get a
sentence instead of a pydantic trace. country deliberately keeps NO
default: uk and us are different tax-benefit models and guessing would
silently score the wrong country.
Adds core.validate_reform() as the single validator behind every tool that
accepts a reform (household, household impact, population, score_reform, the
OG and OBR bridges). It accepts flat values and single-date keys, returns the
normalised dict, and raises ValueError naming the supported shapes with a
worked example. _og_build_policy now honours dated values too.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Restore .github/workflows to main
The previous commit was made from a stale checkout and unintentionally
reverted the workflow changes from #35. This restores all four workflow
files to their state on main, leaving this branch's diff scoped to the
reform-input validation in integration/.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six-agent sweep:
Site — every page's copy shortened (index −18%, docs −16% words) and accuracy-aligned; fixed the homepage 'idea' section that still omitted FRB/US; nav label unified; all 18 internal links + 4 PDFs verified.
Papers — each gains comparisons vs the latest numbers and publications, plus a full referee pass:
E2E test — all six areas pass: site, hosted MCP (10 tools, household math exact, £6.463bn score), local CLI, frbus package (10 tests, −0.55% reproduces), CI green on all four repos, papers build clean.
🤖 Generated with Claude Code